Add attachment_data_id to file attachments #9641
Draft
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to follow on from alphagov/publishing-api#2994 As described there, the lack of attachment_data_id in the data for file asset attachments in content store makes it hard to request the attachments on the server side. Instead, we have to redirect users to the assets, which has led to ugly workarounds like CSV previews being rendered by frontend but served on assets.publishing.service.gov.uk. Adding attachment_data_id should allow the frontends to request attachments directly, using the API client: GdsApi.asset_manager.media(attachment_data_id, filename) This should make it much more convenient to preview assets, or use them for other rendering purposes (e.g. showing a CSV as a line graph).
catalinailie
reviewed
Feb 7, 2025
| def attachment_data_id | ||
| return unless csv? && attachable.is_a?(Edition) && attachment_data.all_asset_variants_uploaded? | ||
|
|
||
| attachment_data.id |
There was a problem hiding this comment.
I'm not sure attachment_data.id is the ID we want. GdsApi.asset_manager expects the asset's ID, and that one, in whitehall, is Asset.asset_manager_id.
I think this is the reason why we have this scenario with preview_url formed in whitehall using attachment_data.id and then overwritten in government-frontend with the URL that has this asset_manager_id in it (formed here I think, but I might be wrong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to follow on from alphagov/publishing-api#2994
As described there, the lack of attachment_data_id in the data for file asset attachments in content store makes it hard to request the attachments on the server side. Instead, we have to redirect users to the assets, which has led to ugly workarounds like CSV previews being rendered by frontend but served on assets.publishing.service.gov.uk.
Adding attachment_data_id should allow the frontends to request attachments directly, using the API client:
This should make it much more convenient to preview assets, or use them for other rendering purposes (e.g. showing a CSV as a line graph).