-
Notifications
You must be signed in to change notification settings - Fork 256
Wcag retirement testing #4550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wcag retirement testing #4550
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for putting together! A couple of thoughts to discuss around the Accessibility headings: Re: naming
Re: placement on page. |
71d467e
to
2db3b4b
Compare
2db3b4b
to
674b040
Compare
…d pages Remove wcag tag in password input
674b040
to
3711aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks @calvin-lau-sig7
@owenatgov pointed out that it might be worth "generifying" the WCAG call out template (ie: let it take a different colour, title, etc) and make it a "Callout" component that we can repurpose for any things we want to call out. |
Closing this, as we've taken a different approach in #4661, so this is now duplicated. |
No description provided.