Skip to content

Wcag retirement testing #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Wcag retirement testing #4550

wants to merge 4 commits into from

Conversation

Ciandelle
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 24, 2025

You can preview this change here:

Name Link
🔨 Latest commit 52228a7
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/67e29746a6d1820008ab17e9
😎 Deploy Preview https://deploy-preview-4550--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@calvin-lau-sig7
Copy link
Contributor

calvin-lau-sig7 commented Mar 25, 2025

Thanks for putting together! A couple of thoughts to discuss around the Accessibility headings:

Re: naming
Should we call it "Accessibility" or something else? I'm mindful that we don't want to make people think the heading covers all possible accessibility issues. Some other ideas:

  • Accessibility considerations
  • Meeting accessibility criteria
  • Accessibility tips

Re: placement on page.
I think towards the end just before "Research on this component" is probably a good place. But I'd like to hear if we can justify putting it further up and avoid the perception of accessibility being an afterthought.

@calvin-lau-sig7 calvin-lau-sig7 force-pushed the wcag-retirement-testing branch from 71d467e to 2db3b4b Compare March 25, 2025 11:03
@calvin-lau-sig7 calvin-lau-sig7 force-pushed the wcag-retirement-testing branch from 2db3b4b to 674b040 Compare March 25, 2025 11:19
@calvin-lau-sig7 calvin-lau-sig7 force-pushed the wcag-retirement-testing branch from 674b040 to 3711aa3 Compare March 25, 2025 11:23
Copy link
Contributor Author

@Ciandelle Ciandelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks @calvin-lau-sig7

@calvin-lau-sig7 calvin-lau-sig7 linked an issue Apr 3, 2025 that may be closed by this pull request
8 tasks
@domoscargin
Copy link
Contributor

@owenatgov pointed out that it might be worth "generifying" the WCAG call out template (ie: let it take a different colour, title, etc) and make it a "Callout" component that we can repurpose for any things we want to call out.

@calvin-lau-sig7
Copy link
Contributor

Closing this, as we've taken a different approach in #4661, so this is now duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire WCAG tags and guidance on rebrand pages
3 participants