Fix file remove component #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencdaly
previously approved these changes
Feb 11, 2025
jamie-o-wilkinson
force-pushed
the
fix-file-remove-component
branch
2 times, most recently
from
e46af0f to
0112f72
Compare
Move the error summary of the FileRemoveComponent to the top, so that it appears above the h1 in accordance with the design system.
The file remove component used the two-thirds grid layout, but the view that contains this component already uses this so the end result was too narrow.
Customise the summary list key width to 20% for the file review component, to allow for long filenames.
jamie-o-wilkinson
force-pushed
the
fix-file-remove-component
branch
2 times, most recently
from
0112f72 to
b66f449
Compare
|
stephencdaly
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Move the error summary of the FileRemoveComponent to the top, so that it appears above the h1 in accordance with the design system.
Remove the
govuk-grid-column-two-thirdsgrid layout from the FileRemoveComponent view, as it was nested within another, making it too narrow.Customise the summary list key width to 20% for the file review component, to allow for long filenames.
Trello card: https://trello.com/c/mfhj3ufe
Things to consider when reviewing