Speed up and fix form_documents_service_spec #2467
Merged
+20
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The tests weren't evaluating the enumerator returned by `#form_documents` meaning they were not actually asserting the collection contained the expected elements. - Remove some unnecessary setup creating Forms and GroupForms when it wasn't necessary, speeding up the tests. - Remove some repeated tests that were unnecessary.
stephencdaly
force-pushed
the
speed-up-form-documents-service-spec
branch
from
143a7c2 to
0407887
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2467.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
DavidBiddle
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests weren't evaluating the enumerator returned by
#form_documentsmeaning they were not actually asserting the collection contained the expected elements.Remove some unnecessary setup creating Forms and GroupForms when it wasn't necessary, speeding up the tests.
Remove some repeated tests that were unnecessary.