Merge pull request #1227 from alphagov/log-dataset-errors

Log errors coming from elasticsearch indexing

Author: kentsanggds

app/models/dataset.rb

@@ -1,4 +1,5 @@
 require "elasticsearch/model"
+require "logger"
 require "securerandom"
 
 class Dataset < ApplicationRecord
@@ -36,6 +37,8 @@ def publish
       result = __elasticsearch__.index_document(id: uuid)
       raise "Failed to publish" if result["_shards"]["failed"].positive?
     end
+  rescue StandardError => e
+    Rails.logger.error e
   end
 
   def unpublish
@@ -45,6 +48,8 @@ def unpublish
     raise "Failed to unpublish" if result["_shards"]["failed"].positive?
 
     draft!
+  rescue StandardError => e
+    Rails.logger.error e
   end
 
   def as_indexed_json(_options = {})

spec/models/dataset_spec.rb

@@ -48,7 +48,7 @@
       allow(subject.__elasticsearch__).to receive(:index_document)
         .and_return("_shards" => { "failed" => 1 })
 
-      expect { subject.publish }.to raise_error(/Failed to publish/)
+      expect { subject.publish }.to_not raise_error(/Failed to publish/)
       expect(subject.reload.published?).to be_falsey
     end
   end
@@ -74,7 +74,7 @@
       allow(subject.__elasticsearch__).to receive(:delete_document)
         .and_return("_shards" => { "failed" => 1 })
 
-      expect { subject.unpublish }.to raise_error(/Failed to unpublish/)
+      expect { subject.unpublish }.to_not raise_error(/Failed to unpublish/)
       expect(subject.published?).to be_truthy
     end
   end