Merge pull request #1226 from alphagov/truncate-metadata_date

metadata_date should be in the form YYYY-MM-DD

Author: kentsanggds

app/models/ckan/v26/package.rb

@@ -9,9 +9,13 @@ def get(key)
         @package[key]
       end
 
-      def get_extra(key)
+      def get_extra(key, max_length = 0)
         @extras ||= hashify(@package["extras"] || [])
-        @extras[key]
+        if max_length.positive? && @extras[key].present?
+          @extras[key][0, max_length]
+        else
+          @extras[key]
+        end
       end
 
       def get_harvest(key)

app/services/ckan/v26/inspire_mapper.rb

@@ -14,7 +14,7 @@ def call(package)
           harvest_object_id: package.get_extra("harvest_object_id") || package.get_harvest("harvest_object_id"),
           harvest_source_reference: package.get_extra("harvest_source_reference"),
           import_source: package.get_extra("import_source"),
-          metadata_date: package.get_extra("metadata-date"),
+          metadata_date: package.get_extra("metadata-date", 10),
           metadata_language: package.get_extra("metadata-language"),
           provider: package.get_extra("provider"),
           resource_type: package.get_extra("resource-type"),

spec/factories/ckan_v26_package.rb

@@ -39,7 +39,7 @@
       add_attribute("harvest_object_id") { SecureRandom.uuid }
       add_attribute("harvest_source_reference") { SecureRandom.uuid }
       add_attribute("import_source") { "harvest" }
-      add_attribute("metadata-date") { "2018-06-05" }
+      add_attribute("metadata-date") { "2018-06-05T11:00:00" }
       add_attribute("metadata-language") { "eng" }
       add_attribute("provider") { "" }
       add_attribute("resource-type") { "dataset" }

spec/services/ckan/v26/inspire_mapper_spec.rb

@@ -18,7 +18,7 @@
       expect(attributes[:harvest_object_id]).to eq package.get_extra("harvest_object_id")
       expect(attributes[:harvest_source_reference]).to eq package.get_extra("harvest_source_reference")
       expect(attributes[:import_source]).to eq package.get_extra("import_source")
-      expect(attributes[:metadata_date]).to eq package.get_extra("metadata-date")
+      expect(attributes[:metadata_date]).to eq package.get_extra("metadata-date", 10)
       expect(attributes[:metadata_language]).to eq package.get_extra("metadata-language")
       expect(attributes[:provider]).to eq package.get_extra("provider")
       expect(attributes[:resource_type]).to eq package.get_extra("resource-type")