sprint 9 #2
Merged
sprint 9 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-lenkevich
suggested changes
May 27, 2022
| @@ -0,0 +1,7 @@ | |||
| package ru.yandex.practicum.filmorate.exception; | |||
|
|
|||
| public class FilmNotFoundException extends RuntimeException{ | |||
There was a problem hiding this comment.
А необходимо ли тут (и ниже) непроверяемое исключение?
Пользователь ввел некорректные данные, фильм не найден и т.д. и т.п. - вполне себе штатная ситуация, пусть тут будет проверяемое исключение :)
extends Exception
| } | ||
|
|
||
| public void like(long filmId, long userId){ | ||
| if (filmStorage.getById(filmId).isPresent()){ |
There was a problem hiding this comment.
Тут можно сделать несколько короче, раз уж Optional :)
ifPresent(...).orElseThrow()
| log.debug("film.getName().isEmpty(): {}", film.getName()); | ||
| return false; | ||
| } | ||
| if (film.getName().isBlank()) { |
There was a problem hiding this comment.
Тут можно использовать
StringUtils.hasText
или же аналогичную функцию из apache commons
StringUtils.isNotBlank
=)
eugene-lenkevich
approved these changes
May 29, 2022
There was a problem hiding this comment.
Все супер, спасибо!
PS про исключения посмотри во это, может пригодиться :)
https://habr.com/ru/post/528116/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.