Skip to content

Fix inherited PowerShell module paths in Windows SSH ACL setup - #840

Merged
alphaxiv-bot[bot] merged 2 commits into
alphaXiv:mainfrom
chrisx599:fix/windows-ssh-powershell-module-path
Oct 31, 2026
Merged

alphaxiv-bot[bot] merged 2 commits into
alphaXiv:mainfrom
chrisx599:fix/windows-ssh-powershell-module-path

Conversation

@chrisx599

Copy link
Copy Markdown
Contributor

Summary

Starting orx from PowerShell 7 can pass an incompatible PSModulePath to the Windows PowerShell 5.1 subprocess used for SSH directory permissions. Its first Get-Acl then fails to autoload Microsoft.PowerShell.Security, and SSH/Slurm readiness reports only a private-directory error.

Remove PSModulePath from that ACL subprocess so Windows PowerShell builds its own compatible search path. Add a Windows regression that starts a fresh test process with an incompatible Security module before the built-in module directory; it exercises the real private_directory function without changing the parent test environment.

Closes #839.

This complements #834, which addresses the separate repeated-Set-Acl/SeSecurityPrivilege failure in #824. The module-loading failure occurs before that setter.

Test plan

  • Native Windows PowerShell 5.1: inherited PowerShell 7 module path fails at module autoload; removing the child variable succeeds on a fresh directory.
  • Controlled incompatible-module fixture: baseline fails at module autoload; removing the child variable succeeds.
  • Official rustfmt 1.99.1: rustfmt --edition 2021 --check src/jobs/ssh/service/mod.rs.
  • git diff --check.
  • Rust/Clippy and full Windows test suite: GitHub CI; a native Rust build environment is unavailable locally.

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Fixes Windows SSH directory setup when orx inherits incompatible PowerShell module paths.

  • Windows SSH directory checks use Windows PowerShell's own security module.

Review was based on source inspection; Windows tests were not run.

Reviews (1) · Last reviewed commit: "Fix inherited PowerShell module paths in..." · Reviewed by Greptile

@paperclover paperclover added the auto-merge Queue for automatic merge once all checks pass label Oct 30, 2026
@alphaxiv-bot
alphaxiv-bot Bot merged commit 115e5d5 into alphaXiv:main Oct 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Queue for automatic merge once all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows SSH ACL setup inherits incompatible PowerShell 7 modules

2 participants