Repository navigation
Fix inherited PowerShell module paths in Windows SSH ACL setup - #840
Merged
alphaxiv-bot[bot] merged 2 commits intoOct 31, 2026
Merged
alphaxiv-bot[bot] merged 2 commits into
alphaxiv-bot[bot] merged 2 commits into
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryFixes Windows SSH directory setup when
Review was based on source inspection; Windows tests were not run. Reviews (1) · Last reviewed commit: "Fix inherited PowerShell module paths in..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting
orxfrom PowerShell 7 can pass an incompatiblePSModulePathto the Windows PowerShell 5.1 subprocess used for SSH directory permissions. Its firstGet-Aclthen fails to autoloadMicrosoft.PowerShell.Security, and SSH/Slurm readiness reports only a private-directory error.Remove
PSModulePathfrom that ACL subprocess so Windows PowerShell builds its own compatible search path. Add a Windows regression that starts a fresh test process with an incompatible Security module before the built-in module directory; it exercises the realprivate_directoryfunction without changing the parent test environment.Closes #839.
This complements #834, which addresses the separate repeated-
Set-Acl/SeSecurityPrivilegefailure in #824. The module-loading failure occurs before that setter.Test plan
rustfmt --edition 2021 --check src/jobs/ssh/service/mod.rs.git diff --check.