Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support position intent in order requests #428

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: Support position intent in order requests #428

merged 1 commit into from
Mar 27, 2024

Conversation

matebudai
Copy link
Contributor

@matebudai matebudai commented Mar 22, 2024 •
edited
Loading

Context

Changes

  • trading enums are extended with a class called PositionIntent
  • order request accept this as a new optional parameter
    BUY_TO_OPEN = "buy_to_open"
    BUY_TO_CLOSE = "buy_to_close"
    SELL_TO_OPEN = "sell_to_open"
    SELL_TO_CLOSE = "sell_to_close"

@matebudai matebudai requested a review from hiohiohio as a code owner March 22, 2024 08:31
@matebudai matebudai force-pushed the order-request-position-intent branch from 96ead7b to 076c0c9 Compare March 22, 2024 10:06
hiohiohio
hiohiohio approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matebudai matebudai merged commit 390b043 into master Mar 27, 2024
12 checks passed
@matebudai matebudai deleted the order-request-position-intent branch March 27, 2024 16:14
@OlegRa OlegRa mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiohiohio hiohiohio hiohiohio approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matebudai @hiohiohio