Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix optional fields of CorporateActionAnnouncement model #426

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix: Fix optional fields of CorporateActionAnnouncement model #426

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d174f6
fix: fix CorporateActionAnnouncement model
hiohiohio Mar 21, 2024
069bc56
Merge branch 'master' into fix-corporate-action-announcement
hiohiohio Mar 22, 2024
4bd6b3e
fix: add test case of missing optional fields for get_corporate_annou…
hiohiohio Mar 26, 2024
3933912
fix: fix CorporateActionAnnouncement model
hiohiohio Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions alpaca/trading/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,10 +573,10 @@ class CorporateActionAnnouncement(ModelWithID):
ca_sub_type (CorporateActionSubType): The specific subtype of corporate action that was announced.
initiating_symbol (str): Symbol of the company initiating the announcement.
initiating_original_cusip (str): CUSIP of the company initiating the announcement.
target_symbol (str): Symbol of the child company involved in the announcement.
target_original_cusip (str): CUSIP of the child company involved in the announcement.
declaration_date (date): Date the corporate action or subsequent terms update was announced.
ex_date (date): The first date that purchasing a security will not result in a corporate action entitlement.
target_symbol (Optional[str]): Symbol of the child company involved in the announcement.
target_original_cusip (Optional[str]): CUSIP of the child company involved in the announcement.
declaration_date (Optional[date]): Date the corporate action or subsequent terms update was announced.
ex_date (Optional[date]): The first date that purchasing a security will not result in a corporate action entitlement.
record_date (date): The date an account must hold a settled position in the security in order to receive the
corporate action entitlement.
payable_date (date): The date the announcement will take effect. On this date, account stock and cash
Expand All @@ -591,10 +591,10 @@ class CorporateActionAnnouncement(ModelWithID):
ca_sub_type: CorporateActionSubType
initiating_symbol: str
initiating_original_cusip: str
target_symbol: Optional[str]
target_original_cusip: Optional[str]
declaration_date: Optional[date]
ex_date: Optional[date]
target_symbol: Optional[str] = None
target_original_cusip: Optional[str] = None
declaration_date: Optional[date] = None
ex_date: Optional[date] = None
record_date: date
payable_date: date
cash: float
Expand Down
Loading