feat: add exercise_options_position #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neal
reviewed
Mar 1, 2024
neal
reviewed
Mar 1, 2024
alpaca/trading/client.py
Outdated
| @@ -317,6 +321,28 @@ def close_position( | |||
|
|
|||
| return Order(**response) | |||
|
|
|||
| def exercise_option_contract( | |||
There was a problem hiding this comment.
or maybe not as this is what we call it in the docs
There was a problem hiding this comment.
Thank you! agreed to rename!
Co-authored-by: Neal Patel <[email protected]>
matebudai
reviewed
Mar 1, 2024
alpaca/trading/client.py
Outdated
| None | ||
| """ | ||
| symbol_or_contract_id = validate_symbol_or_contract_id(symbol_or_contract_id) | ||
| response = self.post( |
There was a problem hiding this comment.
I believe response is unused. Not sure if you wanted to log or something.
There was a problem hiding this comment.
Good catch! Please let me remove it.
matebudai
reviewed
Mar 1, 2024
alpaca/common/utils.py
Outdated
| if isinstance(symbol_or_contract_id, (UUID, str)): | ||
| return symbol_or_contract_id | ||
| raise ValueError( | ||
| f"symbol_or_contract_id must be a UUID of an contract id or a string of a symbol." |
There was a problem hiding this comment.
f-string, but there are no interpolated variables
There was a problem hiding this comment.
Thank you! Removed.
matebudai
reviewed
Mar 1, 2024
alpaca/common/utils.py
Outdated
| """ | ||
| A helper function to eliminate duplicate checks of symbols or contract id. | ||
|
|
||
| If the argument given is a string, assumed to be a symbol name. If a UUID object, assumed to be an contract id. |
matebudai
approved these changes
Mar 1, 2024
hiohiohio
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Changes: