Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add get option contracts #405

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat: Add get option contracts #405

merged 2 commits into from
Jan 25, 2024

Conversation

hiohiohio
Copy link
Contributor

Context:

  • a new api endpoint, options/contracts are introduced

Changes:

  • support options contracts api endpoint

matebudai
matebudai approved these changes Jan 24, 2024
View reviewed changes
AlexandrosKyriakakis
AlexandrosKyriakakis approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@AlexandrosKyriakakis AlexandrosKyriakakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Just take care the comments from @matebudai

@OlegRa OlegRa mentioned this pull request Jan 24, 2024
Closed
2 tasks
@hiohiohio hiohiohio merged commit bc831eb into master Jan 25, 2024
12 checks passed
@hiohiohio hiohiohio deleted the add-get-option-contract branch January 25, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrosKyriakakis AlexandrosKyriakakis AlexandrosKyriakakis approved these changes

@matebudai matebudai matebudai approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@gnvk gnvk Awaiting requested review from gnvk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiohiohio @AlexandrosKyriakakis @matebudai