Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adjust enums for trading #404

Merged
merged 2 commits into from
Jan 24, 2024
Merged

feat: Adjust enums for trading #404

merged 2 commits into from
Jan 24, 2024

Conversation

hiohiohio
Copy link
Contributor

Context:

  • as a preparation of option trade

Changes:

  • add us_option
  • adjust docstrings

AlexandrosKyriakakis
AlexandrosKyriakakis approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@AlexandrosKyriakakis AlexandrosKyriakakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiohiohio hiohiohio merged commit 8e28e7f into master Jan 24, 2024
12 checks passed
@hiohiohio hiohiohio deleted the adjust-enums-for-trading branch January 24, 2024 12:37
@OlegRa OlegRa mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrosKyriakakis AlexandrosKyriakakis AlexandrosKyriakakis approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@gnvk gnvk Awaiting requested review from gnvk

@matebudai matebudai Awaiting requested review from matebudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiohiohio @AlexandrosKyriakakis