Android kmp library #422
Open
Android kmp library #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alorma
force-pushed
the
androidKMPLibrary
branch
from
3758eff to
4470624
Compare
alorma
force-pushed
the
androidKMPLibrary
branch
from
e377198 to
542ec7c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates Android multiplatform modules from the traditional Android library plugin to the new Android KMP (Kotlin Multiplatform) library plugin, streamlining the build configuration for multiplatform projects.
- Replaces
androidLibraryplugin withandroidKmpLibraryplugin across all UI modules - Consolidates Android configuration into the Kotlin multiplatform block using
androidLibrarytarget - Comments out desktop/JVM targets and related configuration
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui-tiles/build.gradle.kts | Migrates to androidKmpLibrary plugin and consolidates Android config |
| ui-tiles-extended/build.gradle.kts | Migrates to androidKmpLibrary plugin and consolidates Android config |
| ui-base/build.gradle.kts | Migrates to androidKmpLibrary plugin and consolidates Android config |
| samples/shared/build.gradle.kts | Migrates to androidKmpLibrary plugin and consolidates Android config |
| samples/desktopApp/build.gradle.kts | Comments out JVM target configuration |
| gradle/libs.versions.toml | Adds androidKmpLibrary plugin definition |
| androidLibrary { | ||
| namespace = libs.versions.namespace.get() + ".sample.shared" | ||
| compileSdk = libs.versions.android.compileSdk.get().toInt() | ||
| minSdk = libs.versions.android.minSdk.get().toInt() |
There was a problem hiding this comment.
The minSdk configuration uses libs.versions.android.minSdk but the commented-out android block was using libs.versions.android.minSdkSample. This change may result in incorrect minimum SDK version for the sample module.
Suggested change
| minSdk = libs.versions.android.minSdk.get().toInt() | |
| minSdk = libs.versions.android.minSdkSample.get().toInt() |
Comment on lines
+81
to
+87
| /* | ||
| val desktopMain by getting | ||
| desktopMain.dependencies { | ||
| api(compose.desktop.currentOs) | ||
| implementation(compose.desktop.common) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| android { | ||
| namespace = libs.versions.namespace.get() + ".sample.shared" | ||
| compileSdk = | ||
| libs.versions.android.compileSdk | ||
| .get() | ||
| .toInt() | ||
|
|
||
| sourceSets["main"].manifest.srcFile("src/androidMain/AndroidManifest.xml") | ||
| sourceSets["main"].res.srcDirs("src/androidMain/res") | ||
| sourceSets["main"].resources.srcDirs("src/commonMain/resources") | ||
|
|
||
| defaultConfig { | ||
| minSdk = | ||
| libs.versions.android.minSdkSample | ||
| .get() | ||
| .toInt() | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| targetCompatibility = JavaVersion.VERSION_17 | ||
| */ |
There was a problem hiding this comment.
The desktopMain source set configuration is commented out but still referenced in the sourceSets block. This creates incomplete configuration that may cause build issues when desktop support is re-enabled.
alorma
force-pushed
the
androidKMPLibrary
branch
from
542ec7c to
043ef06
Compare
alorma
force-pushed
the
androidKMPLibrary
branch
from
043ef06 to
778f510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.