Skip to content

Unwrap TargetInvocationException when returning step result #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: nunit-refactorings-1
Choose a base branch
from
Open

Unwrap TargetInvocationException when returning step result #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Allure.NUnit.Examples/AllureStepTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ public static void StepWithParams(object firstParam, object lastParam)
Console.WriteLine(firstParam);
Console.WriteLine(lastParam);
}

[AllureStep("This step should fail")]
public static int FailedStep()
{
var x = 1;
return 1 / (1 - x);
}
}

[AllureSuite("Tests - Steps")]
Expand Down Expand Up @@ -70,5 +77,12 @@ public void SimpleStepTest2()
StepsExamples.StepWithParams(1, 2);
StepsExamples.StepWithParams(new[] { 1, 3, 5}, "array");
}

[Test]
[AllureName("Should fail on step")]
public void TestWithFailedStep()
{
Assert.That(()=> StepsExamples.FailedStep(), Throws.TypeOf<DivideByZeroException>());
}
}
}
11 changes: 9 additions & 2 deletions Allure.NUnit/Core/Steps/AllureStepAspect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,15 @@ public object Around(
}
else
{
return SyncHandler.MakeGenericMethod(returnType)
.Invoke(this, new object[] { target, args, metadata, stepName, stepParameters });
try
{
return SyncHandler.MakeGenericMethod(returnType)
.Invoke(this, new object[] { target, args, metadata, stepName, stepParameters });
}
catch (TargetInvocationException e)
{
throw e.InnerException ?? e;
}
}
}

Expand Down