Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename groups to state_masks in hash builder #86

Merged
merged 2 commits into from
Feb 17, 2025
Merged

chore: rename groups to state_masks in hash builder #86

merged 2 commits into from
Feb 17, 2025

Conversation

shekhirin
Copy link
Contributor

groups naming is inconsistent with state_masks that we have everywhere else

@shekhirin shekhirin force-pushed the alexey/hash-builder-groups-rename branch from 5c38906 to 702b719 Compare February 17, 2025 13:03
@shekhirin shekhirin force-pushed the alexey/hash-builder-groups-rename branch from 702b719 to d9e9f67 Compare February 17, 2025 13:05
rkrasiuk
rkrasiuk approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strictly better

@shekhirin shekhirin merged commit 1825c77 into main Feb 17, 2025
21 checks passed
@shekhirin shekhirin deleted the alexey/hash-builder-groups-rename branch February 17, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @rkrasiuk