Expose Serde support for ProofNodes and DecodedProofNodes
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
startup-dreamer
requested review from
DaniPopes,
gakonst and
rkrasiuk
as code owners
mattsse
approved these changes
Feb 12, 2025
| @@ -14,6 +14,7 @@ use alloc::vec::Vec; | |||
| /// data associated with the full key. When searching the trie for a specific key, reaching a leaf | |||
| /// node means that the search has successfully found the value associated with that key. | |||
| #[derive(PartialEq, Eq, Clone)] | |||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | |||
There was a problem hiding this comment.
this seems okay, although this will serialize the value as array, should be okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intends to close: #79