Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: temporarily allow missing const for fn #82

Closed
wants to merge 1 commit into from
Closed

chore: temporarily allow missing const for fn #82

wants to merge 1 commit into from

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Feb 7, 2025

This is still sending false positives

mattsse
mattsse reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we dont expect a lot of prs here, so I guess we could also just wait this one out?

@Rjected
Copy link
Contributor Author

Rjected commented Feb 7, 2025

yeah, I guess we could wait this one out, can force merge any PRs I need personally

@Rjected Rjected closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse