feat(providers): wrapped provider
#171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Jan 6, 2025
mattsse
requested changes
Feb 3, 2025
Comment on lines
+15
to
+23
| /// Creates and returns an implementation of the [`Provider`] trait. | ||
| async fn get_provider(url: &str) -> TransportResult<impl Provider> { | ||
| ProviderBuilder::new().on_builtin(url).await | ||
| } | ||
|
|
||
| /// Simple free function to get the latest block number. | ||
| async fn get_block_number<P: Provider>(provider: &P) -> TransportResult<u64> { | ||
| provider.get_block_number().await | ||
| } |
There was a problem hiding this comment.
can get remove these standalone functions?
these look a bit weird and you wouldn't write it like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref alloy-rs/alloy#1859
Solution
Demonstrate how to pass a provider in a free function and wrap it in a custom type
Merge after
alloy 0.1bumpPR Checklist