Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tx type bound to Encodable2718 and Decodable2718 #584

Closed
wants to merge 3 commits into from
Closed

feat: add tx type bound to Encodable2718 and Decodable2718 #584

wants to merge 3 commits into from

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Apr 19, 2024

Closes #540

@leruaa
Copy link
Contributor Author

leruaa commented Apr 19, 2024

Adapting AnyNetwork lead to a few questions: I wonder if I should create AnyTxEnvelope and AnyTransaction structs for N::TxEnvelope and N::UnsignedTx bounds?

@prestwich
Copy link
Member

Adapting AnyNetwork lead to a few questions: I wonder if I should create AnyTxEnvelope and AnyTransaction structs for N::TxEnvelope and N::UnsignedTx bounds?

Yes, although each of those should be a separate issue + PR

This was referenced Apr 23, 2024
Closed
Closed
@onbjerg onbjerg added the enhancement New feature or request label Apr 24, 2024
@prestwich
Copy link
Member

After stewing on this for a month (sorry) I think this is currently over-abstraction. I'd want to re-approach this idea in the future, potentially as an assoc type instead of a generic trait, AFTER AnyTxEnvelope and AnyTransaction

@prestwich prestwich closed this May 21, 2024
@leruaa leruaa deleted the en_decodable2718_generic branch October 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] Make En/Decodable2718 generic over a tx type
3 participants
@leruaa @prestwich @onbjerg