fix(pubsub): retry connecting to backend
#2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Mar 28, 2025
| break Err(e) | ||
| } | ||
| } | ||
|
|
||
| _ = &mut self.handle.error => { | ||
| error!("Pubsub service backend error."); | ||
| if let Err(e) = self.reconnect().await { | ||
| error!("Reconnect failed, shutting down: {e}"); |
There was a problem hiding this comment.
I think we still want this error message
There was a problem hiding this comment.
yash-atreya
commented
Mar 28, 2025
Comment on lines
+208
to
+213
| error!( | ||
| "Reconnect failed after {} attempts, shutting down: {e}", | ||
| retry_count | ||
| ); | ||
| break Err(e); | ||
| } |
There was a problem hiding this comment.
It prints here @mattsse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2252
Solution
PubsubServicePR Checklist