feat(provider): watch_full_blocks
#2194
Conversation
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
|
|
||
| /// Consumes the stream of block hashes from the inner [`PollerBuilder`] and maps it to a stream | ||
| /// of [`BlockResponse`]. | ||
| pub fn into_stream(self) -> impl Stream<Item = TransportResult<BlockResp>> + Unpin { |
There was a problem hiding this comment.
if we return anonymous types then this should also enforce Send because this can't be inferred on the callsite
but this is likely problematic for wasm compat
There was a problem hiding this comment.
we don't do this anywhere for streams
There was a problem hiding this comment.
this however means we can't send this stream, e.g. for background monitoring.
maybe this limitation is fine but doesn't sound ideal, we could roll our own stream type that this generic over the future so that Send is auto impl.
but this can also be a followup
There was a problem hiding this comment.
you can call into_stream after sending, but yes ideally these are all named types...
|
|
||
| /// Consumes the stream of block hashes from the inner [`PollerBuilder`] and maps it to a stream | ||
| /// of [`BlockResponse`]. | ||
| pub fn into_stream(self) -> impl Stream<Item = TransportResult<BlockResp>> + Unpin { |
There was a problem hiding this comment.
we don't do this anywhere for streams
|
|
||
| /// Consumes the stream of block hashes from the inner [`PollerBuilder`] and maps it to a stream | ||
| /// of [`BlockResponse`]. | ||
| pub fn into_stream(self) -> impl Stream<Item = TransportResult<BlockResp>> + Unpin { |
There was a problem hiding this comment.
this however means we can't send this stream, e.g. for background monitoring.
maybe this limitation is fine but doesn't sound ideal, we could roll our own stream type that this generic over the future so that Send is auto impl.
but this can also be a followup
| @@ -496,6 +496,36 @@ pub trait Provider<N: Network = Ethereum>: Send + Sync { | |||
| Ok(PollerBuilder::new(self.weak_client(), "eth_getFilterChanges", (id,))) | |||
| } | |||
|
|
|||
| /// Watch for new blocks by polling the provider with | |||
There was a problem hiding this comment.
shouldn't this be just watch_blocks().full() instead of a separate method?
There was a problem hiding this comment.
I'd like to keep it as a different method because if we want to get a block with full txns we'll have to do watch_blocks().await?.full().full_txns() vs watch_full_blocks().await?.full()
Motivation
Partially addresses #325
Solution
WatchBlocksWatchBlocksconsumes the stream of block hashes fromPollerBuilderand maps it toStream<Item = TransportResult<BlockResponse>PR Checklist