Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove Service impls for &T #1973

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore!: remove Service impls for &T #1973

merged 1 commit into from
Jan 30, 2025

Conversation

DaniPopes
Copy link
Member

Remove an unused and unusable layer of indirection, as we require Transport: 'static.

@DaniPopes DaniPopes changed the title chore: remove Service impls for &T chore!: remove Service impls for &T Jan 30, 2025
@DaniPopes DaniPopes force-pushed the dani/rm-service-ref branch from 1efbdd7 to 78d8d0a Compare January 30, 2025 20:06
Remove an unused and unusable layer of indirection, as we require
`Transport: 'static`.
@DaniPopes DaniPopes force-pushed the dani/rm-service-ref branch from 78d8d0a to 919da4b Compare January 30, 2025 20:07
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah these are also clone, so impl for & not useful

@mattsse mattsse merged commit bb77d2f into main Jan 30, 2025
27 checks passed
@mattsse mattsse deleted the dani/rm-service-ref branch January 30, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants