fix: map txcount resp

[mattsse]

closes #1940

inlines macro and adds the required map

[chain-lover]

I see that no loading from cache for get_transaction_count. Is it on purpose or only for fixing the bug?

alloy/crates/provider/src/layers/cache.rs

Lines 339 to 369 in bb9f516

	fn get_transaction_count(&self, address: Address) -> RpcWithBlock<Address, U64, u64> {
	let client = self.inner.weak_client();
	let cache = self.cache.clone();
	RpcWithBlock::new_provider(move |block_id| {
	let req = RequestType::new("eth_getTransactionCount", address).with_block_id(block_id);
	let client = client
	.upgrade()
	.ok_or_else(|| TransportErrorKind::custom_str("RPC client dropped"));
	let cache = cache.clone();
	ProviderCall::BoxedFuture(Box::pin(async move {
	let client = client?;
	let result = client
	.request(req.method(), req.params())
	.map_resp(utils::convert_u64 as fn(U64) -> u64)
	.map_params(|params| ParamsWithBlock {
	params,
	block_id: req.block_id.unwrap_or(BlockId::latest()),
	});
	let res = result.await?;
	// Insert into cache.
	let json_str = serde_json::to_string(&res).map_err(TransportErrorKind::custom)?;
	let hash = req.params_hash()?;
	let _ = cache.put(hash, json_str);
	Ok(res)
	}))
	})
	}

[mattsse]

oh you're right,
we don't want to cache txcount because this can change at any point, so we probably should just delete this override

wdyt @yash-atreya ?

tbh not exactly sure why this even exists then @yash-atreya ?

[yash-atreya]

oh you're right,

we don't want to cache txcount because this can change at any point, so we probably should just delete this override

wdyt @yash-atreya ?

tbh not exactly sure why this even exists then @yash-atreya ?

This caches responses for specific block hashes/number but not for tags.

Can remove it, though