feat: couple convenience methods #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
mattsse
requested changes
Jan 27, 2025
crates/consensus/src/block/header.rs
Outdated
Comment on lines
338
to
346
| /// True if the Cancun hardfork is active. | ||
| pub const fn cancun_active(&self) -> bool { | ||
| self.blob_gas_used.is_some() | ||
| } | ||
|
|
||
| /// True if the Prague hardfork is active. | ||
| /// | ||
| /// This function checks that the withdrawals root is present. | ||
| pub const fn prague_active(&self) -> bool { |
There was a problem hiding this comment.
since this is the ethereum header type, I think this makes sense because these fields were introduced with the corresponding hardforks. although this assumes that the header is valid, but I think we can do this.
the alternative would be has_withdrawals_root and then the caller is expected to know that this means hardfork active
There was a problem hiding this comment.
these will also need to be updated if any field is removed in future hard forks, but that seems unlikely (and also fine)
mattsse
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple convenience methods to check if hard forks are active in a given header
PR Checklist