feat: improve node bindings #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
added
the
blocked
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
5 tasks
mattsse
approved these changes
Sep 12, 2024
zerosnacks
removed
the
blocked
|
Removing Requesting final review before merging |
mattsse
approved these changes
Sep 12, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* add run_with_tempdir * update tests, now picks random instance by default * document new random port picking * fix clippy * add port customization * reset instance when configuring custom port as this is incompatible in reth * additional tests for http_port(0) * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improves on existing Reth bindings and other node bindings.
Supersedes #1076
Solution
instance(0)to use the default ports.run_with_tempdir_*utility methods to better handle automatic cleaning up and adding of prefixes so that cleaning up the/tmpfolder manually becomes easierutilsinnode-bindingsnamespaced, allowing to import utilities likerun_with_tempdir_*whilst sitting behind a namespace to avoid polluting the scope.I've decided not to include the hardcoded
keysandaddressesas proposed in #1076 as it is easy to derive if necessary and it is out of scope for Alloy.PR Checklist