Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Make En/Decodable2718 generic over a tx type #540

Closed
prestwich opened this issue Apr 15, 2024 · 4 comments
Closed

[Refactor] Make En/Decodable2718 generic over a tx type #540

prestwich opened this issue Apr 15, 2024 · 4 comments

Comments

@prestwich
Copy link
Member

prestwich commented Apr 15, 2024 •
edited
Loading

I want to incorporate a txtype enum into En/Decodable2718, and make something like trait En/Decodable2718<T: Into<u8> + TryFrom<u8, Error = _>> or similar so that we can enforce that the 2718 implementation uses the network TxType via a type TxEnvelope: Encodable2718<Self::TxType> bound

Originally posted by @prestwich in #431 (comment)
@leruaa
Copy link
Contributor

leruaa commented Apr 15, 2024

I can work on this

@prestwich
Copy link
Member Author

please hold off for a bit until mattsse reviews the existing PR :)

@leruaa
Copy link
Contributor

leruaa commented Apr 16, 2024

Yes I saw ;)

@leruaa leruaa mentioned this issue Apr 19, 2024
Closed
@mattsse
Copy link
Member

mattsse commented Jan 31, 2025

I think we can close this because we've changed rlp a few times since this issue and I'm quite happy with it now

@mattsse mattsse closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add tx type bound to Encodable2718 and Decodable2718 leruaa/alloy
3 participants
@leruaa @prestwich @mattsse