Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] resolve consensus::Header vs rpc_types::Header #439

Closed
2 tasks
prestwich opened this issue Apr 2, 2024 · 2 comments
Closed
2 tasks

[Feature] resolve consensus::Header vs rpc_types::Header #439

prestwich opened this issue Apr 2, 2024 · 2 comments
Labels
debt Tech debt which needs to be addressed enhancement New feature or request

Comments

@prestwich
Copy link
Member

Component

consensus, eips, genesis, network, json-rpc

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

continuation of #399

  • Add serde for alloy_consensus::Header
  • Embed the object or dedupe with alloy_rpc_types::Header as appropriate
@prestwich prestwich added enhancement New feature or request debt Tech debt which needs to be addressed labels Apr 2, 2024
@prestwich prestwich mentioned this issue Apr 2, 2024
Closed
@rkdud007
Copy link

rkdud007 commented Apr 3, 2024

  • would love to have account as well

@DaniPopes DaniPopes added this to the 0.1-rc.0 milestone Jun 5, 2024
@DaniPopes DaniPopes removed the 0.1-rc.0 label Jun 5, 2024
@prestwich prestwich removed this from the 0.1-rc.0 milestone Jun 5, 2024
@mattsse
Copy link
Member

mattsse commented Jan 31, 2025

closing as completed

@mattsse mattsse closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@prestwich @mattsse @DaniPopes @rkdud007