Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dedupe alloy_network::TransactionList and alloy_rpc_types::BlockTransactions #440

Closed
prestwich opened this issue Apr 2, 2024 · 3 comments
Closed

[Bug] Dedupe alloy_network::TransactionList and alloy_rpc_types::BlockTransactions #440

prestwich opened this issue Apr 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@prestwich
Copy link
Member

prestwich commented Apr 2, 2024 •
edited
Loading

Component

consensus, eips, genesis, network, json-rpc

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

Related to #439

These types are duplicated
@prestwich prestwich added the bug Something isn't working label Apr 2, 2024
@prestwich prestwich mentioned this issue Apr 2, 2024
Closed
@yash-atreya yash-atreya mentioned this issue Apr 2, 2024
Merged
3 tasks
@yash-atreya
Copy link
Member

yash-atreya commented Apr 2, 2024 •
edited
Loading

TransactionList is in alloy_network

@prestwich
Copy link
Member Author

my bad 😅

@prestwich prestwich changed the title [Bug] Dedupde alloy_consensus::TransactionList and alloy_rpc_types::BlockTransactions [Bug] Dedupde alloy_network::TransactionList and alloy_rpc_types::BlockTransactions Apr 2, 2024
@DaniPopes DaniPopes changed the title [Bug] Dedupde alloy_network::TransactionList and alloy_rpc_types::BlockTransactions [Bug] Dedupe alloy_network::TransactionList and alloy_rpc_types::BlockTransactions Apr 3, 2024
@yash-atreya
Copy link
Member

Can be closed #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestwich @yash-atreya