Add support for Recipe component #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnelle
reviewed
Feb 11, 2025
| ], | ||
| 'recipe_background_color_dark' => [ | ||
| 'default' => '', | ||
| 'label' => __( 'Recipe background color', 'apple-news' ), |
There was a problem hiding this comment.
Do these dark colors need additional labeling to specify that they're for the dark variant (here and on line 1371, 1381, etc...)?
There was a problem hiding this comment.
In practice, they appear in a dedicated section of fields for dark mode.
scottnelle
reviewed
Feb 11, 2025
| } | ||
|
|
||
| // Second, try to find schema in the HEAD of the post on the frontend. | ||
| // Could check BODY as well, but the post content is already being scanned. That might be enough. |
There was a problem hiding this comment.
Any update needed to this comment after testing in development?
There was a problem hiding this comment.
This is the "serious" revision of the comment 😆 But I wanted to leave it because I don't really know whether it will be confirmed when actual sites start to use the feature and leave feedback about whether the schema is being picked up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.