Issue 1039 Part 2 #1045
Merged
Issue 1039 Part 2 #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes encompass various refactoring actions for apple exporter header class. These include implementing proper namespace usage, correctly declaring array data types, specifying return types as well as enhancing PHPDoc comments for methods for better code clarity and readability. Additionally, the future plan to remove duplicate methods across child classes is marked with a TODO comment.
In the `test-class-heading.php` and `test-class-parser.php` tests, an ID has been added to the heading in the HTML content. Several test functions have been updated to explicitly specify 'void' as the return type. Apart from these, a small tweak was made to streamline the HTML parsing verification logic.
Updated the class-heading component to include 'identifier' key for heading IDs. Adjusted regular expression in the build function to capture heading ID value, if set, from HTML input. This addition enhances navigation and provides anchor links to headings.
…you phpunit, you are my only hope.
rpasillas
reviewed
Jan 22, 2024
rpasillas
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the anchor link feature started in #1044 , keeping new changes separate for ease of reviewing.