feat: add FeatureDB vpc privatelink support #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceding
reviewed
Feb 10, 2025
dao/feature_view_featuredb_dao.go
Outdated
| @@ -110,23 +105,51 @@ func (d *FeatureViewFeatureDBDao) GetFeatures(keys []interface{}, selectFields [ | |||
| pkeys = append(pkeys, utils.ToString(k, "")) | |||
| } | |||
| body, _ := json.Marshal(map[string]any{"keys": pkeys}) | |||
| d.featureDBClient.AddressMutex.RLock() | |||
There was a problem hiding this comment.
这里用锁，感觉不是特别高效。 而且代码有点冗余散落到各处。 是不是直接提供 GetCurrentAddress, 如果失败的话， 获取 GetNextAddress 就可以了。 至于 内部的 current address, next address, 是不是异步线程监听切换就好了。
There was a problem hiding this comment.
d.featureDBClient.CheckVpcAddress(3) 这个阻塞的切换有点耗RT
bruceding
reviewed
Feb 11, 2025
datasource/featuredb/featuredb.go
Outdated
| return | ||
| } | ||
| retryCount++ | ||
| resp, err := f.Client.Do(req) |
There was a problem hiding this comment.
这里需不需要resp body 显示的 close 下？
bruceding
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.