edits to CardView.m Card.m and GameView.m for Mavericks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaddTheSane
pushed a commit
to MaddTheSane/freecell
that referenced
this pull request
Oct 4, 2018
Create GNUmakefile
MaddTheSane
reviewed
Oct 13, 2018
| //[image compositeToPoint: origin | ||
| // operation: operation | ||
| // fraction: card == nil? 0.5 : 1.0 ]; | ||
| [ image drawAtPoint: origin fromRect: frame operation: operation |
There was a problem hiding this comment.
It’s probably better to send fromRect: an NSZeroRect. From the documentation:
If you pass in
NSZeroRect, the entire image is drawn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Alisdair,
I'm just getting my feet wet with git, and your Freecell project is one that I've been tinkering with a little bit this week. It took me forever to upgrade from SnowLeopard even to Mavericks (just in the last couple of months), so I'm also just getting my feet wet with the coding changes that come with Mavericks. Your project is really solid as far as avoiding deprecated code, and I only had to change compositeToPoint: invocations to drawAtPoint: in a couple of files, and adjust a couple of int variables to NSUInteger or NSInteger. This fork of your project now builds without any issues I can detect under Mavericks, in case you want to update. I don't know whether the changes will put any squeeze on a user base with older systems. Cheers, and thanks for creating this project, which has afforded me many hours of entertainment over the years.
Dan Stein / dyne2meter