Skip to content

fix: sparse vector indices should be ordered#382

Merged
zhourrr merged 9 commits intoalibaba:mainfrom
zhourrr:fix/sparse_vector_order
May 7, 2026
Merged

fix: sparse vector indices should be ordered#382
zhourrr merged 9 commits intoalibaba:mainfrom
zhourrr:fix/sparse_vector_order

Conversation

@zhourrr
Copy link
Copy Markdown
Collaborator

@zhourrr zhourrr commented Apr 30, 2026

This should fix #379

@zhourrr zhourrr requested a review from Cuiyus as a code owner April 30, 2026 08:51
@zhourrr zhourrr requested a review from chinaux April 30, 2026 08:51
@zhourrr
Copy link
Copy Markdown
Collaborator Author

zhourrr commented May 6, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@JalinWang
Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/binding/python/model/param/python_param.cc Outdated
Comment thread tests/db/index/common/doc_test.cc Outdated
Comment thread src/binding/python/model/param/python_param.cc Outdated
@zhourrr zhourrr force-pushed the fix/sparse_vector_order branch from d4c61aa to c8ef09e Compare May 7, 2026 06:03
@zhourrr zhourrr requested a review from feihongxu0824 as a code owner May 7, 2026 07:15
@zhourrr
Copy link
Copy Markdown
Collaborator Author

zhourrr commented May 7, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Copy link
Copy Markdown
Collaborator

@chinaux chinaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhourrr zhourrr merged commit 68a497e into alibaba:main May 7, 2026
5 of 12 checks passed
@zhourrr zhourrr deleted the fix/sparse_vector_order branch May 8, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sparse vector search returns different results based on element insertion order

3 participants