refactor: use std::filesystem to refactor file_helper to support utf8 path on Windows #359
Merged
JalinWang merged 22 commits intoalibaba:mainfrom May 8, 2026
Merged
Conversation
zhourrr
reviewed
Apr 21, 2026
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors file/path handling to consistently support UTF-8 paths, with a focus on Windows compatibility.
fix: #339
What Changed
ailego::FileHelperaroundstd::filesystemUTF-8 <-> wide string)PathJoin,OpenIfstream, andOpenOfstreamhelpers for UTF-8-safe path and stream handling"/"into pathsVersionand adjusted a few tests/assertions around path behaviorTests
Added coverage for:
ifstream/ofstream