Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with dynamic libssl #389

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

iczero
Copy link
Contributor

@iczero iczero commented Dec 18, 2023

The cmake build will always statically link libssl and libcrypto. In some cases, it may be preferable to dynamically link them. This adds -DSSL_DYNAMIC=1 which will build libxquic dynamically linked to libssl and libcrypto and also disable libxquic-static.

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2023

CLA assistant check
All committers have signed the CLA.

CMakeLists.txt Outdated Show resolved Hide resolved
@iczero
Copy link
Contributor Author

iczero commented Dec 20, 2023

Rebased and fixed the format problem.

Please note the "not found" message is no longer required. If the library is not found, cmake will print the following:

-- Could NOT find SSL (missing: SSL_LIBRARY_STATIC CRYPTO_LIBRARY_STATIC) 
CMake Error at CMakeLists.txt:63 (message):
  ssl module not found

Copy link
Collaborator

@Kulsk Kulsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kulsk Kulsk merged commit dadd924 into alibaba:main Dec 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants