Skip to content

chore: remove unnecessary time convert #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: remove unnecessary time convert #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions util/time.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ import (
)

const (
TimeFormat = "2006-01-02 15:04:05"
DateFormat = "2006-01-02"
UnixTimeUnitOffset = uint64(time.Millisecond / time.Nanosecond)
TimeFormat = "2006-01-02 15:04:05"
DateFormat = "2006-01-02"
)

var (
Expand Down Expand Up @@ -84,7 +83,7 @@ func (t *RealClock) CurrentTimeMillis() uint64 {
if tickerNow > uint64(0) {
return tickerNow
}
return uint64(time.Now().UnixNano()) / UnixTimeUnitOffset
return uint64(time.Now().UnixMilli())
}

func (t *RealClock) CurrentTimeNano() uint64 {
Expand Down Expand Up @@ -120,7 +119,7 @@ func (t *MockClock) Sleep(d time.Duration) {
}

func (t *MockClock) CurrentTimeMillis() uint64 {
return uint64(t.Now().UnixNano()) / UnixTimeUnitOffset
return uint64(t.Now().UnixMilli())
}

func (t *MockClock) CurrentTimeNano() uint64 {
Expand Down Expand Up @@ -272,12 +271,12 @@ func NewTicker(d time.Duration) Ticker {

// FormatTimeMillis formats Unix timestamp (ms) to time string.
func FormatTimeMillis(tsMillis uint64) string {
return time.Unix(0, int64(tsMillis*UnixTimeUnitOffset)).Format(TimeFormat)
return time.Unix(0, int64(tsMillis)*int64(time.Millisecond)).Format(TimeFormat)
}

// FormatDate formats Unix timestamp (ms) to date string
func FormatDate(tsMillis uint64) string {
return time.Unix(0, int64(tsMillis*UnixTimeUnitOffset)).Format(DateFormat)
return time.Unix(0, int64(tsMillis)*int64(time.Millisecond)).Format(DateFormat)
}

// Returns the current Unix timestamp in milliseconds.
Expand Down
2 changes: 1 addition & 1 deletion util/time_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func BenchmarkCurrentTimeInMs(b *testing.B) {
if tickerNow > uint64(0) {
return tickerNow
}
return uint64(time.Now().UnixNano()) / UnixTimeUnitOffset
return uint64(time.Now().UnixMilli())
}

b.ReportAllocs()
Expand Down
4 changes: 2 additions & 2 deletions util/time_ticker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ var nowInMs = uint64(0)
// StartTimeTicker starts a background task that caches current timestamp per millisecond,
// which may provide better performance in high-concurrency scenarios.
func StartTimeTicker() {
atomic.StoreUint64(&nowInMs, uint64(time.Now().UnixNano())/UnixTimeUnitOffset)
atomic.StoreUint64(&nowInMs, uint64(time.Now().UnixMilli()))
go func() {
for {
now := uint64(time.Now().UnixNano()) / UnixTimeUnitOffset
now := uint64(time.Now().UnixMilli())
atomic.StoreUint64(&nowInMs, now)
time.Sleep(time.Millisecond)
}
Expand Down