-
Notifications
You must be signed in to change notification settings - Fork 447
Add adapter for Kratos #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 53.14% 53.14%
=======================================
Files 91 91
Lines 5897 5897
=======================================
Hits 3134 3134
Misses 2415 2415
Partials 348 348 Continue to review full report at Codecov.
|
Why fallback only return error without response? |
|
Hi~Thanks for reply. The reason that |
Thanks, got it, I'll add the reply to this adapter :) For other adapters, maybe a new issue should be open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You can consider submitting directly to Kratos contrib. |
👍 I'll test it on the latest Kratos in these days and try to submit there |
Describe what this PR does / why we need it
#450
Does this pull request fix one issue?
#450
Describe how you did it
The implementation is based on Kratos unified middleware abstractions for http/grpc servers/clients.
Tests on HTTP servers/clients are provided in
server_test.go
andclient_test.go
.Describe how to verify it
The implementation can be verified via
go test
.Special notes for reviews