[feat] add vocab file for features #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengaofei
approved these changes
Feb 5, 2025
poson
reviewed
Feb 9, 2025
| @@ -87,6 +87,9 @@ def num_embeddings(self) -> int: | |||
| num_embeddings = len(self.vocab_list) | |||
| elif len(self.vocab_dict) > 0: | |||
| num_embeddings = max(list(self.vocab_dict.values())) + 1 | |||
| elif len(self.vocab_file) > 0: | |||
| self.init_fg() | |||
| num_embeddings = self._fg_op.vocab_list_size() | |||
| else: | |||
| raise ValueError( | |||
| f"{self.__class__.__name__}[{self.name}] must set hash_bucket_size" | |||
| elif len(self.vocab_file) > 0: | ||
| fg_cfg["vocab_file"] = self.vocab_file | ||
| fg_cfg["default_bucketize_value"] = self.default_bucketize_value | ||
| fg_cfg["value_type"] = "string" | ||
| elif self.config.HasField("num_buckets"): | ||
| fg_cfg["num_buckets"] = self.config.num_buckets | ||
| if self.config.default_value: |
There was a problem hiding this comment.
前面说使用num_buckets，应该是integer。为什么这里当没有设置default_value的时候，要设置string ？ fg_cfg["value_type"] = "string"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.