Open
Conversation
This reverts commit 65a11fd.
* add release note 120 * Revert "add release note 120" This reverts commit 65a11fd. * add version
* feat: add qwen code agent demo and config examples * feat: add cursor CLI demo and config examples
…alibaba#277 (alibaba#423) * delegate sandbox management operations to sandbox operator * chore: add operator factory * refine factory * simplify get status logic
* feat: add http proxy endpoint for sandbox service * chore: update sandbox proxy service imports and return types * feat(sandbox): add POST proxy endpoint and service method * test: update sandbox http proxy test imports * test: add unit test for sandbox proxy router * test: add streaming response test case * test: update sandbox manager test config
* chore: update redis image version in sandbox demo * refactor: remove redundant validation method in RockAgentConfig * feat: add OpenClaw demo guide and config files
* add release note 120 * Revert "add release note 120" This reverts commit 65a11fd. * add v1.2.1 doc
* add release note 120 * Revert "add release note 120" This reverts commit 65a11fd. * fix scheduler task file not found detection
* monitor support user-defined endpoint * add test cases
… (alibaba#451) * feat(sdk): implement close_session method in Sandbox client * fix(test): refine close_session integration test - Use sandbox_instance fixture instead of admin_remote_server - Remove unused unit test file - Revert other changes to align with master --------- Co-authored-by: lianzhanbiao <lianzhanbiao@lianzhanbiaodeMacBook-Air.local>
* add release note 120 * Revert "add release note 120" This reverts commit 65a11fd. * add kata
StephenRi
reviewed
Feb 13, 2026
| """Pause all scheduled jobs by removing them from the scheduler.""" | ||
| for task_type in list(TaskRegistry.get_all_tasks().keys()): | ||
| try: | ||
| self._scheduler.pause_job(task_type) |
Collaborator
There was a problem hiding this comment.
这是什么行为？会把rock worker上的进程干掉？
Collaborator
Author
There was a problem hiding this comment.
scheduler是定时运行一次的，pause就是停止之后的运行，对于运行一次进程一直存在的任务无影响，对于cron任务有影响
Collaborator
There was a problem hiding this comment.
image cleanup不是调用一次，起了一个后台进程嘛。能stop掉？
StephenRi
reviewed
Feb 13, 2026
rock/admin/main.py
Outdated
| set_env_service(sandbox_manager) | ||
|
|
||
| if rock_config.scheduler.enabled and is_primary_pod(): | ||
| # if rock_config.scheduler.enabled and is_primary_pod(): |
Collaborator
There was a problem hiding this comment.
这里啥意思？所有的admin write节点都要起scheduler进程？
Collaborator
Author
There was a problem hiding this comment.
这里是我测试的时候注释的，现在取消注释
StephenRi
reviewed
Feb 13, 2026
rock/admin/scheduler/scheduler.py
Outdated
| ) | ||
|
|
||
| # Override the default update callback with our scheduler-aware callback | ||
| self._nacos_provider._update_callback = self._on_nacos_config_changed |
Collaborator
There was a problem hiding this comment.
这里破坏封装了。不允许这么用，要么你先重构这块
Collaborator
Author
There was a problem hiding this comment.
已经修改，将回调函数作为add_listener方法的参数传入
StephenRi
reviewed
Feb 13, 2026
| cache_ttl=self.scheduler_config.worker_cache_ttl, | ||
| ) | ||
|
|
||
| def _init_nacos_provider(self) -> None: |
Collaborator
There was a problem hiding this comment.
为啥不直接把nacos_provider传进来，还要再构造一遍呢
Collaborator
Author
There was a problem hiding this comment.
Nacos client 内部包含 HTTP 连接、线程、回调函数等，这些都无法通过 pickle 序列化传递给子进程
StephenRi
reviewed
Feb 24, 2026
|
|
||
| import uvicorn | ||
| from fastapi import FastAPI, Request | ||
| from OpenSource.rock.utils.system import is_primary_pod |
StephenRi
reviewed
Feb 24, 2026
| callback: Optional callback function to be called when config changes. | ||
| If not provided, uses the default _update_callback method. | ||
| """ | ||
| if callback is None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #480