-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support to sync params when train_tp divides inference_tp. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoda
reviewed
Sep 23, 2024
adoda
reviewed
Sep 23, 2024
adoda
reviewed
Sep 23, 2024
adoda
reviewed
Sep 23, 2024
adoda
reviewed
Sep 23, 2024
adoda
reviewed
Sep 23, 2024
SeaOfOcean
reviewed
Sep 24, 2024
SeaOfOcean
reviewed
Sep 24, 2024
SeaOfOcean
reviewed
Sep 24, 2024
SeaOfOcean
reviewed
Sep 24, 2024
SeaOfOcean
reviewed
Sep 24, 2024
SeaOfOcean
reviewed
Sep 24, 2024
SeaOfOcean
reviewed
Sep 24, 2024
SeaOfOcean
reviewed
Sep 24, 2024
adoda
approved these changes
Sep 24, 2024
haolin-nju
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway,我觉得我这边review的意见可以分成如下几点:
- TP不对等情况下broadcast是不是在做两阶段的通信?如果追求性能,是不是也需要像TP对等一样实现P2P的通信,再对比P2P和两阶段broadcast的最终效果呢?
- 现在直接上两阶段broadcast的话整体看下来代码比较复杂,如果业务方需求dst_tp < src_tp,或者有一个新的模型定义,可能要对代码进行二次改动,维护成本比较高
- 代码的封装和解耦可能需要再细化一下
- 2 stage的param sync缺少UT,Regression Test成本较高且很难暴露corner case
Resolved: 问题3:之前沟通的时候,建议将tp对等和非对等场景代码分开。也是担心改动影响tp对等场景。所以这版一些能共用的代码我也没有分开,暂时先不做改动,后面再慢慢合并两个场景的支持吧 问题4 ut/ft正准备专门提一个CI |
support for mcore model: #105 |
SeaOfOcean
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.