Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Form): convert to TypeScript, improve docs and tests, close#4585 #4862

Merged
merged 1 commit into from
Sep 23, 2024
Merged

refactor(Form): convert to TypeScript, improve docs and tests, close#4585 #4862

merged 1 commit into from
Sep 23, 2024

Conversation

FairyYang
Copy link
Collaborator

@FairyYang FairyYang commented Jun 17, 2024 •
edited by eternalsky
Loading

close #4585

@eternalsky eternalsky self-requested a review June 19, 2024 12:51
@eternalsky eternalsky changed the base branch from master to next July 29, 2024 07:43
@FairyYang FairyYang force-pushed the refactor-ts-form branch 2 times, most recently from 9176ba0 to 7ab2a7c Compare July 29, 2024 09:52
@FairyYang FairyYang force-pushed the refactor-ts-form branch 2 times, most recently from bc8d63d to b7b001e Compare August 7, 2024 03:08
eternalsky
eternalsky requested changes Aug 8, 2024
View reviewed changes
components/form/__docs__/demo/accessibility/index.tsx Outdated Show resolved Hide resolved
components/form/__docs__/demo/preview/index.tsx Outdated Show resolved Hide resolved
components/form/__docs__/demo/responsive-grid/index.tsx Outdated Show resolved Hide resolved
components/form/__docs__/demo/size/index.tsx Show resolved Hide resolved
components/form/__docs__/demo/validate-basic/index.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
eternalsky
eternalsky requested changes Aug 9, 2024
View reviewed changes
components/form/enhance.tsx Outdated Show resolved Hide resolved
components/form/enhance.tsx Outdated Show resolved Hide resolved
components/form/enhance.tsx Outdated Show resolved Hide resolved
components/form/enhance.tsx Outdated Show resolved Hide resolved
components/form/form.tsx Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
@FairyYang FairyYang changed the title refactor(Form): convert to TypeScript, impove docs and tests, close#4585 refactor(Form): convert to TypeScript, improve docs and tests, close#4585 Aug 23, 2024
eternalsky
eternalsky requested changes Aug 30, 2024
View reviewed changes
components/form/__docs__/demo/accessibility/index.tsx Outdated Show resolved Hide resolved
components/form/__docs__/demo/base/index.tsx Outdated Show resolved Hide resolved
components/form/__docs__/demo/preview/index.tsx Outdated Show resolved Hide resolved
components/form/__docs__/demo/validate-basic/index.tsx Outdated Show resolved Hide resolved
components/form/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
eternalsky
eternalsky requested changes Sep 18, 2024
View reviewed changes
components/form/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/form/form.tsx Outdated Show resolved Hide resolved
components/form/form.tsx Show resolved Hide resolved
components/form/submit.tsx Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/enhance.tsx Outdated Show resolved Hide resolved
eternalsky
eternalsky requested changes Sep 19, 2024
View reviewed changes
components/form/types.ts Outdated Show resolved Hide resolved
components/form/types.ts Outdated Show resolved Hide resolved
components/form/form.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
components/form/__tests__/validate-spec.tsx Outdated Show resolved Hide resolved
components/form/enhance.tsx Outdated Show resolved Hide resolved
@eternalsky eternalsky merged commit d609eac into alibaba-fusion:next Sep 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternalsky eternalsky eternalsky approved these changes

Assignees
No one assigned
Labels
Technical Upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【Technical upgrade】Form
2 participants
@FairyYang @eternalsky