feat(CascaderSelect): should support clear search value in multiple mode #3008 #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunMeng99
changed the title
YunMeng99
changed the title
YunMeng99
changed the title
eternalsky
changed the title
eternalsky
changed the title
|
你好，该 pr 已 30 天没有活动，因此被标记为 stale，如果之后的 7 天仍然没有活动，该 pr 将被自动关闭 |
eternalsky
requested changes
Jun 11, 2024
| @@ -687,6 +692,9 @@ class CascaderSelect extends Component { | |||
| ); | |||
| // 更新缓存 | |||
| this.refreshValueDataCache(value); | |||
| if(clearSearchOnSelect && searchValue){ | |||
There was a problem hiding this comment.
这里和 703 行对于 searchValue 的处理逻辑为什么是分开的，并且还不一样？
There was a problem hiding this comment.
@eternalsky 已修改
YunMeng99
force-pushed
the
feat/CascaderSelect-selected-clear-value
branch
3 times, most recently
from
65aa5c9 to
e24481b
Compare
eternalsky
requested changes
Jun 20, 2024
eternalsky
changed the title
YunMeng99
force-pushed
the
feat/CascaderSelect-selected-clear-value
branch
from
eb8d4ef to
2d05244
Compare
eternalsky
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should support empty search value after selection close #3008