Skip to content

Upgrade minimum Python version to 3.10 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

michaeldiamant
Copy link
Contributor

#244 - Upgrades minimum Python version 3.10.

Details:

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there is a reference to 3.7 in the .readthedocs.yml file as well.

@michaeldiamant michaeldiamant requested a review from algochoi April 11, 2022 19:30
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked our readthedocs settings, and I believe no other actions need to be taken for this upgrade, though we should verify the docs build successfully after this is merged.

edit: I now see our branch protections rules for older versions need to be removed. I'll make that change now

@michaeldiamant michaeldiamant merged commit d26deaa into algorand:master Apr 12, 2022
@michaeldiamant michaeldiamant deleted the min_python_version_310 branch April 12, 2022 14:12
algoidurovic pushed a commit to algoidurovic/pyteal that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants