-
Notifications
You must be signed in to change notification settings - Fork 70
feat: add in simulate function for ATC and EmptyTransactionSigner #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaeltchuang
wants to merge
6
commits into
algorand:main
Choose a base branch
from
michaeltchuang:feat/add-reti-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
10043d4
feat: add in simulate function for ATC and EmptyTransactionSigner
michaeltchuang c628b69
fix: accept suggested changes
michaeltchuang 730cf72
fix: address more PR feedback
michaeltchuang 3ee0c42
fix: add in first batch of integration tests
michaeltchuang f39ea1d
test: add in ATC unsigned transaction simulate integration tests
michaeltchuang 9281c78
test: add in simulate tag and a few more test steps
michaeltchuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
src/main/java/com/algorand/algosdk/transaction/EmptyTransactionSigner.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
package com.algorand.algosdk.transaction; | ||
|
||
import com.algorand.algosdk.crypto.Address; | ||
import java.security.NoSuchAlgorithmException; | ||
import java.util.Objects; | ||
|
||
public class EmptyTransactionSigner implements TxnSigner { | ||
|
||
private String authAddr; | ||
/** | ||
* EmptyTransactionSigner is a TransactionSigner that produces signed transaction objects without | ||
* signatures. This is useful for simulating transactions, but it won't work for actual submission. | ||
*/ | ||
public EmptyTransactionSigner(String authAddr) { | ||
super(); | ||
this.authAddr = authAddr; | ||
} | ||
|
||
/** | ||
* SignTransactions returns SignedTxn bytes but does not sign them. | ||
* | ||
* @param txnGroup The group of transactions to be signed. | ||
* @param indicesToSign The indexes of the transactions to sign. | ||
* @return A list of signed transaction bytes. | ||
*/ | ||
@Override | ||
public SignedTransaction[] signTxnGroup(Transaction[] txnGroup, int[] indicesToSign) throws NoSuchAlgorithmException { | ||
SignedTransaction[] stxs = new SignedTransaction[indicesToSign.length]; | ||
|
||
for (int pos : indicesToSign) { | ||
SignedTransaction stx = new SignedTransaction(txnGroup[pos]); | ||
|
||
try { | ||
if (authAddr != null) { | ||
Address address = new Address(authAddr); | ||
stx.authAddr(address.getBytes()); | ||
} | ||
} catch (IllegalArgumentException ignored) { } | ||
|
||
stxs[pos] = stx; | ||
} | ||
return stxs; | ||
} | ||
|
||
/** | ||
* Equals returns true if the other TransactionSigner equals this one. | ||
* | ||
* @param other The other TransactionSigner to compare. | ||
* @return true if equal, false otherwise. | ||
*/ | ||
@Override | ||
public boolean equals(Object other) { | ||
return other instanceof EmptyTransactionSigner; | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(EmptyTransactionSigner.class); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,4 @@ | |
@rekey_v1 | ||
@send | ||
@send.keyregtxn | ||
@simulate |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.