-
Notifications
You must be signed in to change notification settings - Fork 518
network: add vote compression benchmarks and related algodump flags #6467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess! That's a lot of code. I guess it benchmarks?
I don't see much reason not to approve a tooling addition.
|
@jannotti removed/shrunk some things and it is now less code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6467 +/- ##
==========================================
- Coverage 51.13% 46.95% -4.19%
==========================================
Files 668 659 -9
Lines 112101 88652 -23449
==========================================
- Hits 57327 41623 -15704
+ Misses 51907 44276 -7631
+ Partials 2867 2753 -114 ☔ View full report in Codecov by Sentry. |
f0045e9 to
4eae592
Compare
Summary
This provides benchmark code and algodump tooling for capturing network traffic and running compression on it with different window sizes, used during the development of #6351 and #6276.
Test Plan
Tools-only change.