Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Oct 17, 2025

Summary

This follows #6351 by integrating it with the WebsocketNetwork implementation, using a new VP message tag.

Test Plan

New tests added to exercise table size negotiation & success + failure scenarios. Stateful encoder/decoder errors should still keep connection alive, switching off compression immediately and letting votes continue to pass through. Ran swarm performance tests.

Co-authored-by: Pavel Zbitskiy <[email protected]>
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 83.13253% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.38%. Comparing base (495da8c) to head (6e1eeae).
⚠️ Report is 7 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
network/msgCompressor.go 72.15% 17 Missing and 5 partials ⚠️
config/localTemplate.go 0.00% 15 Missing ⚠️
network/wsPeer.go 94.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6466      +/-   ##
==========================================
- Coverage   47.44%   47.38%   -0.07%     
==========================================
  Files         666      659       -7     
  Lines       88310    88415     +105     
==========================================
- Hits        41900    41896       -4     
- Misses      43649    43748      +99     
- Partials     2761     2771      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

algorandskiy
algorandskiy previously approved these changes Oct 21, 2025
algorandskiy
algorandskiy previously approved these changes Oct 21, 2025
gmalouf
gmalouf previously approved these changes Oct 24, 2025
@cce cce dismissed stale reviews from gmalouf and algorandskiy via 775d9ec October 27, 2025 14:59
@cce cce force-pushed the vpack-dynamic-network branch from 775d9ec to ff7aeb1 Compare October 27, 2025 15:00
gmalouf
gmalouf previously approved these changes Oct 27, 2025
algorandskiy
algorandskiy previously approved these changes Oct 28, 2025
algorandskiy
algorandskiy previously approved these changes Oct 30, 2025
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good docs update!

@cce cce requested a review from jannotti October 31, 2025 03:15
gmalouf
gmalouf previously approved these changes Oct 31, 2025
jannotti
jannotti previously approved these changes Nov 3, 2025
@cce cce dismissed stale reviews from jannotti, gmalouf, and algorandskiy via 6e1eeae November 3, 2025 16:28
@cce cce requested review from algorandskiy and gmalouf November 3, 2025 16:58
@cce cce merged commit da20eba into algorand:master Nov 3, 2025
39 checks passed
@cce cce deleted the vpack-dynamic-network branch November 3, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants