-
Notifications
You must be signed in to change notification settings - Fork 517
network: add VP message type for stateful vote compression #6466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Pavel Zbitskiy <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6466 +/- ##
==========================================
- Coverage 47.44% 47.38% -0.07%
==========================================
Files 666 659 -7
Lines 88310 88415 +105
==========================================
- Hits 41900 41896 -4
- Misses 43649 43748 +99
- Partials 2761 2771 +10 ☔ View full report in Codecov by Sentry. |
775d9ec to
ff7aeb1
Compare
algorandskiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good docs update!
6e1eeae
Summary
This follows #6351 by integrating it with the WebsocketNetwork implementation, using a new VP message tag.
Test Plan
New tests added to exercise table size negotiation & success + failure scenarios. Stateful encoder/decoder errors should still keep connection alive, switching off compression immediately and letting votes continue to pass through. Ran swarm performance tests.