network: wsnet with p2p backup meshing strategy #6391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6391 +/- ##
==========================================
- Coverage 50.68% 50.49% -0.19%
==========================================
Files 661 654 -7
Lines 110682 110699 +17
==========================================
- Hits 56097 55900 -197
- Misses 51724 51927 +203
- Partials 2861 2872 +11 ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/ws-relays-p2p-backup
branch
from
127b66b to
4f7a7ca
Compare
algorandskiy
changed the title
libp2p pubsub can connect to PX streams so that we could end up with more than GossipFanout outgoing peers. This PR marks explicitly dialed peers using peerstore metadata so that each connection can be checked and vetted
algorandskiy
force-pushed
the
pavel/ws-relays-p2p-backup
branch
from
4f7a7ca to
dd1293d
Compare
algorandskiy
force-pushed
the
pavel/ws-relays-p2p-backup
branch
from
c47fd05 to
7187dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the following changes:
hybridRelayMeshCreatorfor relays: use WS as a primary source of peers and fallback to p2p nodesdialNodeoutgoing connects (such as made by pubsub to peers learned from PX).GossipFanoutDNSBootstrapID = "") most likely caused to non-existing DNS records lookup timeout - if it takes longer thanEventuallytimeout for connectivity assertions tests fail.addressData->psmdkAddressDatavariable rename to standardize with other keys by usingpsmdkprefix.Related: #6045
Test Plan
Added unit tests
Performance cluster tests summary: 8k TPS (as expected for hybrid), 7+1 or 6+2 (ws+p2p) outgoing connections (as expected as well).