fix(crawler): skip forbidden crawlers in list and surface non-JSON API errors#267
Open
LorrisSaintGenez wants to merge 1 commit into
Open
fix(crawler): skip forbidden crawlers in list and surface non-JSON API errors#267LorrisSaintGenez wants to merge 1 commit into
LorrisSaintGenez wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 17 |
| Duplication | 4 |
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
algolia crawler listfailed withinvalid character 'F' looking for beginning of valuewhen any crawler returned a 403: the API answers with plain-textForbidden, which the client tried to parse as JSON.APIError{StatusCode, Message}, falling back to the raw body when it isn't JSONcrawler listskips crawlers the API key can't access instead of abortingTest