Skip to content

fix(clients): correctly deserialize SearchResult #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 14, 2025

🧭 What and Why

🎟 JIRA Ticket: CR-7011 CR-8307

The SearchResult deserialization is not working in java because the generic type T is getting erased by java, we need to use all the information about the type to deserialize it into the proper type.

@millotp millotp requested a review from a team as a code owner April 14, 2025 14:51
@millotp millotp requested review from morganleroi and Fluf22 April 14, 2025 14:51
@millotp millotp self-assigned this Apr 14, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 14, 2025

✔️ Code generated!

Name Link
🪓 Triggered by bcbd53147bc58ab88cc789a065cfe74165fc6d2a
🍃 Generated commit 90f6f27c7b52fc4d4d1e0d43b475f764f8b4dd0a
🌲 Generated branch generated/fix/java-deser
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1647
go 1631
php 1502
csharp 1279
java 1087
python 1086
ruby 795
swift 706
scala 23

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏻

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@millotp millotp enabled auto-merge (squash) April 14, 2025 15:01
@millotp millotp merged commit 4570f18 into main Apr 14, 2025
29 checks passed
@millotp millotp deleted the fix/java-deser branch April 14, 2025 15:05
algolia-bot added a commit that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Apr 14, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants